Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor as last post-processor #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fancsali
Copy link

Fixes issue #2.

Other processors/extensions may generate headings, that might need to be
downgraded. A prime example is the built-in raw HTML processing, that
removes inline HTML processes the actual markdown, and then -- in a
preprocessor -- puts the removed raw HTML back.

To avoid this, the header downgrade logic has been moved to a
postprocessor with a low priority (5) to make sure it's the last thing
running.
Enable the user to add 'headdown="0"' to the tag, and make the
extension skip this heading.
@SaschaCowley
Copy link
Owner

This will break on headings that have other attributes set.

@fancsali
Copy link
Author

You are completely right; it's a good shout. Apparently I missed the last commit. ;)

@Kristinita
Copy link

@SaschaCowley, please merge this pull request or specify the reasons for rejecting it when you have time.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants